Skip to content

fix(gitlab): use custom annotation for CI#1760

Merged
openshift-merge-bot[bot] merged 3 commits intoredhat-appstudio:mainfrom
CryptoRodeo:sscui-83
Mar 20, 2026
Merged

fix(gitlab): use custom annotation for CI#1760
openshift-merge-bot[bot] merged 3 commits intoredhat-appstudio:mainfrom
CryptoRodeo:sscui-83

Conversation

@CryptoRodeo
Copy link
Contributor

@CryptoRodeo CryptoRodeo commented Mar 19, 2026 •
edited by coderabbitai bot
Loading

Swap gitlab.com/project-id annotation check for custom annotation gitlab.com/enabled.

JIRA: SSCUI-83

Summary by CodeRabbit

  • Bug Fixes
    • Updated GitLab integration detection to use the correct enablement indicator when determining whether to display GitLab pipelines content in the platform.

@CryptoRodeo
fix(gitlab): use custom annotation for CI
f5d2d82 
Swap `gitlab.com/project-id` annotation check for custom annotation
`gitlab.com/enabled`.

JIRA: SSCUI-83

Signed-off-by: Bryan Ramos <bramos@redhat.com>
@openshift-ci openshift-ci bot requested review from prietyc123 and xinredhat March 19, 2026 13:55
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6b5e28ae-4507-4bfe-9555-159e02828aaa

📥 Commits

Reviewing files that changed from the base of the PR and between 73a3e9e and f5d2d82.

📒 Files selected for processing (1)
  • installer/charts/tssc-dh/templates/plugins-content.yaml
📝 Walkthrough

Walkthrough

The GitLab frontend plugin's conditional rendering logic has been updated to check for the gitlab.com/enabled annotation instead of gitlab.com/project-id. This changes which annotation presence determines whether the GitLab pipelines content is rendered in the dynamic plugin mount configuration.

Changes

Cohort / File(s) Summary
GitLab Plugin Frontend Configuration
installer/charts/tssc-dh/templates/plugins-content.yaml		 Updated the hasAnnotation conditional for the GitLab plugin from checking gitlab.com/project-id to gitlab.com/enabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

approved, lgtm

Suggested reviewers

  • jkopriva
  • rhopp
  • Roming22

Poem

🐰 A simple switch from ID to enabled state,
Annotations now flow through a cleaner gate,
The GitLab plugin dances with grace,
Configuration tweaks in the right place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing a GitLab annotation check with a custom one for CI purposes, which matches the core objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@konflux-ci-qe-bot
Copy link

konflux-ci-qe-bot commented Mar 20, 2026

@CryptoRodeo: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.20-qb8bp Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.20-qb8bp

Test results analysis

<not enabled>

OCI Artifact Browser URL

<not enabled>

Roming22
Roming22 approved these changes Mar 20, 2026
View reviewed changes
Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CryptoRodeo, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dfaa8a9 into redhat-appstudio:main Mar 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roming22 Roming22 Roming22 approved these changes

@prietyc123 prietyc123 Awaiting requested review from prietyc123

@xinredhat xinredhat Awaiting requested review from xinredhat

Assignees

@Roming22 Roming22

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CryptoRodeo @konflux-ci-qe-bot @Roming22